Adds a way to register for notifications on config change #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semanticart
requested changes
May 12, 2025
src/__tests__/prefab.test.ts
Outdated
|
|
||
| describe("ConfigChangeNotifier integration", () => { | ||
| let prefab: Prefab; | ||
| // const apiKey = process.env["PREFAB_TEST_API_KEY"] ?? "fallback-api-key-if-not-set"; // apiKey might not be needed if init is fully mocked |
Contributor
There was a problem hiding this comment.
Can we remove this and other conversational comments? e.g. // No longer async
src/__tests__/prefab.test.ts
Outdated
Comment on lines
1428
to
1430
| describe("init with datafile", () => { | ||
| // ... existing code ... | ||
| }); |
semanticart
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a way to register for notifications on config changes; this will be useful for applications that need to "push" config changes into components when the value changes
Testing & Validation
Added tests